Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13371): Refactor: Migrate to TypeScript (from Flow) #726

Merged
merged 27 commits into from
Dec 27, 2023

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Oct 30, 2023

Description of the Changes

Refactor: Migrate playkit to TypeScript (from Flow)

solves FEC-13371

Related PRs
kaltura/kaltura-player-js#661
kaltura/playkit-js-providers#225
kaltura/playkit-js-hls#213
kaltura/playkit-js-dash#254
kaltura/playkit-js-ui#815
https://github.com/kaltura/playkit-js-browserslist-config/pull/1

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold self-assigned this Nov 8, 2023
JonathanTGold added 9 commits November 8, 2023 14:51
src/engines/html5/media-source/adapters/native-adapter.ts Outdated Show resolved Hide resolved
tests/e2e/dimensions.spec.js Show resolved Hide resolved
src/engines/html5/media-source/media-source-provider.ts Outdated Show resolved Hide resolved
src/state/state-manager.ts Outdated Show resolved Hide resolved
src/track/text-track-display.ts Outdated Show resolved Hide resolved
src/types/deferred-promise.ts Show resolved Hide resolved
src/types/interfaces/dom.ts Outdated Show resolved Hide resolved
src/types/playback-options.ts Show resolved Hide resolved
@JonathanTGold JonathanTGold merged commit cceb0c7 into master Dec 27, 2023
11 checks passed
@JonathanTGold JonathanTGold deleted the FEC-13371 branch December 27, 2023 09:03
JonathanTGold added a commit to kaltura/playkit-js-providers that referenced this pull request Dec 27, 2023
JonathanTGold added a commit to kaltura/playkit-js-hls that referenced this pull request Dec 27, 2023
JonathanTGold added a commit to kaltura/playkit-js-dash that referenced this pull request Dec 27, 2023
Refactor: Migrate to TypeScript (from Flow)

Related PRs
kaltura/kaltura-player-js#661
kaltura/playkit-js#726
kaltura/playkit-js-providers#225
kaltura/playkit-js-ui#815
kaltura/playkit-js-hls#213
kaltura/playkit-js-browserslist-config#1

solves FEC-13371

---------

Co-authored-by: JonathanTGold <[email protected]>
borhandarabi pushed a commit to TasvirChi/playchi-js-dash that referenced this pull request May 14, 2024
Refactor: Migrate to TypeScript (from Flow)

Related PRs
kaltura/kaltura-player-js#661
kaltura/playkit-js#726
kaltura/playkit-js-providers#225
kaltura/playkit-js-ui#815
kaltura/playkit-js-hls#213
kaltura/playkit-js-browserslist-config#1

solves FEC-13371

---------

Co-authored-by: JonathanTGold <[email protected]>
borhandarabi pushed a commit to TasvirChi/playchi-js-hls that referenced this pull request May 14, 2024
Refactor: Migration to TypeScript'

Related PRs
kaltura/kaltura-player-js#661
kaltura/playkit-js#726
kaltura/playkit-js-providers#225
kaltura/playkit-js-dash#254
kaltura/playkit-js-ui#815
kaltura/playkit-js-browserslist-config#1

solves FEC-13371


Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
borhandarabi pushed a commit to TasvirChi/playchi-js-providers that referenced this pull request May 14, 2024
Refactor: Migration to TypeScript'

solves FEC-13371

Related PRs
kaltura/kaltura-player-js#661
kaltura/playkit-js#726
kaltura/playkit-js-hls#213
kaltura/playkit-js-dash#254
kaltura/playkit-js-ui#815
kaltura/playkit-js-browserslist-config#1

Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants